Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC 20200304 #47

Merged
merged 2 commits into from
Mar 12, 2020
Merged

IC 20200304 #47

merged 2 commits into from
Mar 12, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Mar 9, 2020

Describe the contribution
Integration Candidate 20200304

Fixes #38 and #40

See PR #43 for more details

Testing performed
CI and Raspbian

Expected behavior changes
#38 - Builds in Raspbian OS
#40 - Consistent naming conventions

System(s) tested on

Additional context
See PR #43 for more details

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz - NASA/GSFC

Update SAMPLE to better correlate with the naming conventions used
elsewhere and documented in the CFE naming conventions

- Put all global runtime data into a single "SAMPLE_AppData" object
- Name all global-scope identifiers consistently with a "SAMPLE_" prefix
- Do not use SAMPLE prefix for members already inside global
- Command handlers named to match the command they process
- Command handlers return an int32 status value
- Telemetry payload defined in a separate structure
- Member names in telemetry struct following convention in the
  CFE naming convention document.
Put the HkTlm buffer into a union to ensure it is aligned
appropriately for conversion to a CFE_SB_Msg_t type.
@astrogeco astrogeco changed the title Ic 20200311 IC 20200304 Mar 10, 2020
@astrogeco astrogeco linked an issue Mar 10, 2020 that may be closed by this pull request
@astrogeco astrogeco merged commit fc02c92 into master Mar 12, 2020
@astrogeco astrogeco deleted the ic-20200226 branch March 13, 2020 14:05
@skliper skliper added this to the 1.2.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent naming in SAMPLE APP fails to build under Raspbian - alignment of pointers
3 participants